Introduction
During lab 04, we were tasked with working on TOML (Tom's Obvious Minimal Language) which allows developers and users to set up environmental variables like ports, hosts, API keys etc... At first, it seemed a little bit harder than it was. We were also supposed to review other' contributors' code via git remote
.
TOML in React
As I described, I thought it was going to be a hard process. However, after a couple of hours of scrolling the react-compatible documentation, which ended up being toml_edit version 0.22.22
. I opened an [Issue #18] describing in all details what am I about to do. Later on, I just added dependency "toml_edit: 0.22.22" inside Cargo.toml
, pushed the changes, and then opened my first Draft Pull-Request. It was a new feature to me, for the reason that I didn't even know it's existence. It is a good feature because until you do not press Request Review
, you may update the code as much as you want without being afraid that is not going to be merged. Eventually, you'll click the button, and the Draft Pull-Request
will become a regular Pull-Request
.
Returning to what I was discussing, I made all the required changes, but I faced an issue that .toml
file that I was trying to generate had inline format like:
api = {base = "...", key = "..."}
However, I needed a table-like format:
[api]
base = ""
key = ""
The example above, which I am currently sharing, was mentioned in the pull-request by the owner of the repository Theo.
I fixed some minor bugs, my pr was merged, and then proceed to reviewing pr that I received.
Git Remote
After completion of my part, I have received Pull-Request in my repository. It was relatively new experience, as it was mandatory to use git remotes for reviewing other's pr. I went through the class materials, and realized that it wasn't that hard. I reviewed the code and found no issues, so I simply merged it.
Conclusion
Once again, it was really fun to contribute on someone's repository because I had to communicate with my partner constantly, receiving his feedback changes were made. TOML
is really interesting thing to work with, and git remotes is another thing I learned. If I were to complete it again, I would definitely do everything the same because that I really enjoyed the process, and have no regrets.
Top comments (0)