DEV Community

5 Rules for Every Code Review

Simc Dev on August 03, 2022

Code reviews are the glue of any effective software engineering team. A code review is the stage at which an engineer requests their changes to be ...
Collapse
 
bwca profile image
Volodymyr Yepishev

No one on your team is going to look through that much code β€” period.

I am one of those people who go through all the code to be reviewed, disregarding of its amount.

Collapse
 
lexlohr profile image
Alex Lohr

One important thing about any code review is to handle criticism - keep it professional and your ego out of it on both sides of the review.

Collapse
 
joaozitopolo profile image
Joao Polo

Open the mind for a new idea πŸ˜„

Collapse
 
devsimc profile image
Simc Dev

True

Collapse
 
pierminatorq_74 profile image
Pierminator

totally true .

Collapse
 
andrewharpin profile image
Andrew Harpin
  1. Automate as much as possible.

Where elements can be done by the machine, do them, computer time is very cheap, compared to the engineer.

Linting, static analysis, unit testing, dynamic analysis (where possible), integration tests.

Anything that allows the reviewer(s) to focus on the details that cannot be covered by the machine analysis.

Collapse
 
nasrulhazim profile image
Nasrul Hazim Bin Mohamad

it's my daily job to review and merge all the PR. it's true very challenging if there's 1000 line of codes to review. πŸ˜…

Collapse
 
devsimc profile image
Simc Dev

How you will mange the review of 1000 lines of code is important.

Collapse
 
nasrulhazim profile image
Nasrul Hazim Bin Mohamad

i will go through which of not following the standard first, before commenting on functionalities wise.

Collapse
 
freedisch profile image
Freedisch

Code review should be the less stressful part 😴

Collapse
 
billypentester profile image
Bilal Ahmad

be an explorer

Collapse
 
lexiebkm profile image
Alexander B.K.

Bookmarked this for reading later

Collapse
 
showcasefloyd profile image
Philip Isaacs • Edited

I often look at my teams PRs and don’t feel like I don’t have any feedback. Is that bad? Am I supposed to put comments in even if the code looks fine too me?