DEV Community

Félix Dion-Robidoux
Félix Dion-Robidoux

Posted on

PSA: Stop using Streams and Reader/Writers to Convert Strings/ByteArrays

#csharp #codequality #dotnet

Stop doing this :

using (var memory = new MemoryStream())
{
    using (StreamWriter writer = new StreamWriter(memory, Encoding.ASCII))
    {
        foreach (var lineData in dataLines)
        {
            writer.WriteLine(lineData);
        }

        writer.Flush();
        return memory.GetBuffer();
    }
}
Enter fullscreen mode Exit fullscreen mode

Just... do this instead :

return Encoding.ASCII.GetBytes(lineData.Join("\n\r"));
Enter fullscreen mode Exit fullscreen mode

Trust me, it's not worth using streams unless you explicitly need to.

Top comments (0)

Read next

mhrastegari profile image

Develop .NET MAUI Apps Using VS Code Without Traditional IDEs

Mohammad Hossein Rastegarinia -

juarezasjunior profile image

Mapping and Manipulating Data with Entity Framework Core

Juarez Júnior -

serhii_korol_ab7776c50dba profile image

Easy way to use DynamoDB locally and manage data.

Serhii Korol -

leandroveiga profile image

Mastering Unit and Integration Testing for Minimal APIs in .NET 8: Best Practices for High-Quality Code

Leandro Veiga -