DEV Community

Jack Harner πŸš€
Jack Harner πŸš€

Posted on

Got My First Pull Request Accepted and Merged

Holy Shit, I Made Something That Someone Else Was Like "Ya, that works."

Check out my tiny little commit to the Dev.to repo here.

It's just a little 1 line change, but holy shit I'm excited.

Thanks Ben/Dev.to Team!

Top comments (30)

Collapse
 
dmahely profile image
Doaa Mahely

Great job!
I recently got my first PR merged to a google repo (!!!) and it felt awesome! It was the only thing I talked about for the rest of the day πŸ˜†
Mind you, it was just fixing a typo, but who knows what the next PR will be πŸ˜„

Collapse
 
jess profile image
Jess Lee

πŸ‘ πŸ‘ πŸ‘ πŸ‘

Collapse
 
jackharner profile image
Jack Harner πŸš€

Happy to help!

Collapse
 
mnayeem profile image
Nayeem Rahman

Haha, first thing I ever did was correct an example in the w3c geometry module specification. Wasn't code (technically HTML I guess), and really all I did is post the issue that got fixed by someone else because I didn't know how to do that shit πŸ€·β€β™‚οΈ but damn was I excited.

Collapse
 
jackharner profile image
Jack Harner πŸš€

It is a great feeling! Can't wait to contribute more.

Collapse
 
mjraadi profile image
Mohammadjavad Raadi

It's absolutely a satisfying feeling to get that "merge notification". I had my first PR to a public repo merged to react.js Farsi docs. Here's a link to it:

github.com/reactjs/fa.reactjs.org/...

Collapse
 
juanfrank77 profile image
Juan F Gonzalez

My first pull request was to one of the repos that looked for contributors. And I would only have found it thanks to dev.to

Collapse
 
guitarkat profile image
Kat • Edited

It's a great feeling to help! :) Thank you for your contributions!

I remember making commits to documentation helping devs to understand concepts or a system so devs can use it more. :)

I do less code PR but put in recommendations for improvements or UX considerations or a suggestion for a fix.

Everything helps! :) Takes a team!

Collapse
 
rbo13 profile image
Richard Burk

Gz! πŸŽ‰

Collapse
 
josephmancuso profile image
Joseph Mancuso

Open source is so incredibly amazing

Collapse
 
edisonywh profile image
Edison Yap • Edited

Awesome man! Any tips for someone to start?

Collapse
 
jackharner profile image
Jack Harner πŸš€

Just dig through repos. The Dev.To is a great one to start. Find a typo or something simple and fix it.

Collapse
 
dandevri profile image
Danny de Vries

πŸŽ‰