TJ Johnson Posted on Oct 17, 2020 How do you go about constructive criticism of code? #discuss Top comments (2) Subscribe Personal Trusted User Create template Templates let you quickly answer FAQs or store snippets for re-use. Submit Preview Dismiss Collapse Expand Alain Van Hout Alain Van Hout Alain Van Hout Follow A software developer with a passion for architecture and an affinity for Java and JavaScript Location Antwerp Joined Jun 17, 2017 • Oct 17 '20 • Edited on Oct 29 • Edited Dropdown menu Copy link Hide Three simple ways to phrase these things is: As a question: What if we ...? How about changing this to ...? Might X also work here? As a further improvement: This approach will work even better if we ... We could also do X here, so that Say it from the point of the team: all the use of 'we' in the previous items Combining the three generally works best in my own experience. Collapse Expand TJ Johnson TJ Johnson TJ Johnson Follow Joined May 15, 2020 • Oct 17 '20 Dropdown menu Copy link Hide There's a camp that you should not give unsolicited criticism. But sometimes problems that go unchecked can end up being your responsibility. How do you reconcile? Code of Conduct • Report abuse Are you sure you want to hide this comment? It will become hidden in your post, but will still be visible via the comment's permalink. Hide child comments as well Confirm For further actions, you may consider blocking this person and/or reporting abuse
Top comments (2)
Three simple ways to phrase these things is:
Combining the three generally works best in my own experience.
There's a camp that you should not give unsolicited criticism. But sometimes problems that go unchecked can end up being your responsibility. How do you reconcile?