DEV Community

Cover image for This is my first project! Please give feedback
Rahman
Rahman

Posted on • Edited on

This is my first project! Please give feedback

Hello, This is my first freecodecamp project . Give me any type of feedback . And how I can improve my frontend effeciency ??

Thank You!

Top comments (9)

Collapse
 
vincenius profile image
Vincent Will

Really good for the first project :)
From design perspective, I'd add some padding on the left and right, at least for mobile view.

For code, you should add some description in the alt="" tags of the images. Also, add a rel="noopener norefferer" to your links if you use target="_blank" because of security reasons (web.dev/external-anchors-use-rel-n...)

But all in all, it's pretty solid :)

Collapse
 
rahmanxyz profile image
Rahman

Amazing .. I learned something new ... thank you brother

Collapse
 
atulcodex profile image
๐Ÿšฉ Atul Prajapati ๐Ÿ‡ฎ๐Ÿ‡ณ

first project me hi, rula diya yaar ๐Ÿ˜ฅ๐Ÿ˜ช

Collapse
 
rahmanxyz profile image
Rahman

yupp bro ๐Ÿ˜ฅ๐Ÿ˜ฅ๐Ÿ˜ฅ๐Ÿ˜ฅ

Collapse
 
h1manshu01 profile image
Himanshu Sharma

๐Ÿ˜„๐Ÿ˜„

Collapse
 
atulcodex profile image
๐Ÿšฉ Atul Prajapati ๐Ÿ‡ฎ๐Ÿ‡ณ

Sure โœŒ๏ธ

Collapse
 
miketalbot profile image
Mike Talbot โญ

Hey that's nice! As Vincent mentioned the only thing I'd also say is padding. It makes it feel cramped when it's jammed up against the edges of the frame. Excellent work though!

Collapse
 
rahmanxyz profile image
Rahman

thank buddy .. after add padding its look better

Some comments may only be visible to logged-in visitors. Sign in to view all comments.