This is my first code review for release 0.3. I was looking for a pull request on the telescope. Because, I am working on the issue of the project which means, I can understand the code easily compare to another project. And I found an pull request from the page which was an issue from the same page that I am working on. So, I went into the pull request and I was surprised because I was assigned to review the pull request. And I found that the professor assigned me to this issue to review it.
This is the screenshot of the page.
After I looked into the code changes, I saw two parts it will be great to fix.
The first issue was not wrong at all, but, it will be better if it is fixed. the part was the person's name in the last contributor was not synchronized. Some are in small letters and some are capitalized. If it is just a GitHub id it is okay to keep it like what the user decided to have. But it is a name of a GitHub account owner, so, I left a comment that it will be better if the name is synchronized to the same format. And as there is a styled class which is "text-capitalize", I added to comment to just simply add that class can fix this error.
And the second one was the length of the GitHub status cards is not the same. All the heights were different. So, I think to left this comment on the pull request. However, just before I leave a new comment. I decided to read the previous comment and it really helped because there was a person who already left this comment on the pull request. So, I just ended up leaving the first on this pull request.
It was interested because I am reviewing another person's pull request which is a page that I am currently working on. It means that there are some more people who are currently working on the same page as me. That makes me motivated to work hard on this pull request and the issue that I am currently working on.
Top comments (0)