I often have a discussion about git commit --amend and git push --force versus git push --force-with-lease with new colleagues.
First things first: it is ok to rewrite commits on your working branches, even already pushed commits. It allows you to remove useless commits and inconsistencies, resulting in a cleaner history.
Rewriting commits seems tricky as a beginner. However, if you want to rewrite the last one, git commit --amend allows you to do it easily. Not only the commit message is alterable, but the content of the commit too (you just have to add or remove some changes before your git commit --amend). This is definitely my main way for editing a commit. More advanced history rewrites may be done with git rebase which is a broad topic I will not discuss in this post.
After changing an already committed work, you will then be forbidden to push it the regular way. The reason is it would result to an inconsistent synchronization between your local machine and the remote. So you have to force your git push. But as you maybe already heard, git push --force is a truly bad habit. This is because, if something changed on the remote, it will not be taken into account. Put it another way, if someone else pushed a commit and you didn't pull it before, the commit will be lost (or more precisely, it will be hard to recover).
Maybe you think git push --force is unavoidable after rewriting your commits history? Spoiler alert: it's not true. The alternative is to use git push --force-with-lease. The --force-with-lease option works somehow like a --force, but will check if you are well synchronized with the remote before pushing. If you are not up-to-date locally, the command fails and warns you. In other words, you are forcing, but safely. This good practice may avoid many “where is that damn commit?!” situations in your team.
I sometimes heard: “I do not git push --force-with-lease but I always git pull before every git push --force”. Unfortunately, this is not enough yet because another push could be done by someone else between the two commands. Rare, but not impossible.
The Git CLI gets nicer these days, e.g. adding in version 2.23 the switch and restore sub-commands to do some stuff checkout is already capable of. Thanks to this update, we have now more suitable verbs to do the job. However, the CLI change I would be the most happy to see is a -f short option bound to the --force-with-lease option of git push. In this case, brutal force short option could use -F instead. Sadly, it would be a breaking change. Nevertheless, I am still passively hoping.
Top comments (0)