Discussion of the Week: "I need feedback on my first website"

After a couple weeks hiatus, I'm coming back at you with another Discussion of the Week. 🙌

In this weekly roundup, we highlight what we believe to be the most thoughtful, helpful, and/or interesting discussion over the past week! Though we are strong believers in healthy and respectful debate, we typically try to choose discussions that are positive and avoid those that are overly contentious.

Any folks whose articles we feature here will be rewarded with our Discussion of the Week badge. ✨

Now that y'all understand the flow, let's go! 🏃💨

The Discussion of the Week

This week's highlighted discussion goes to @ahmadkdev for sharing "I need feedback on my first website."

I need feedback on my first website

Ahmad Khalid ・ Jan 9

#webdev #beginners #css #html

This is exactly what DEV is made for... someone creating something cool, sharing it with the community, and asking for constructive feedback. @ahmadkdev might've just joined, but their already making use of the community like a pro. 🙌

Props to all the kind commenters who hopped in with advice and encouraging words. There's so much genuine guidance in this thread — it's encouraging to see all this good will. To highlight just a few of the good ones:

@ctnkaan hopped in with some helpful advice for improving git commit messages:

Çetin Kaan Taşkıngenç • Jan 9 • Edited on Jan 9 • Edited

It looks quite good for your first project. One recommendation I could give you is to improve your git commit messages. I've seen you make commits like "updated css stuff". This is not a best practice. I used to do commits like these when I first started coding but if you do proper git commits you can show these projects to other developers/recruiters.

I recommend you to check out and use semantic commit messages in the future. You'll get used to it in no time. Keep on coding!

Semantic Git Commits

Meanwhile, @chasm offered up some kind, encouraging words:

Charles F. Munat • Jan 10

Outstanding. A remarkable effort.

Your thinking may align with mine. You can read more about mine at my website, Craft Code, if curious.

I am particularly impressed that you stuck to vanilla code and didn't rush to React or similar; that you managed 100% across the board on Lighthouse and zero errors on axe DevTools (at AAA WCAG 2.2, no less); and that your code, at first glance, appears to conform to semantic HTML and best practies.

You must have put a lot of thought into this.

So, wow! Welcome to coding! We need more like you. I hope you can maintain this "keep it simple" approach, not adding unnecessary frills or pointless dependencies (as at least one commenter has suggested), and using the built-in Web APIs fully. As Arthur Quiller-Couch said, "murder your darlings".

Will try to keep an eye on your work.

And @jennherrarte gave some solid resume guidance:

Jenn Herrarte • Jan 9

super clean! I don't think you need years of experience for each technology, but that's just my person opinion. I think you have a good eye for design.

Go check out Ahmed's portfolio linked in their post and let them know what you think.

What are your picks?

The DEV Community is particularly special because of the kind, thoughtful, helpful, and entertaining discussions happening between community members. As such, we want to encourage folks to participate in discussions and reward those who are initiating or taking part in conversations across the community. After all, a community is made possible by the people interacting inside it.

There are loads of great discussions floating about in this community. This is just the one we chose to highlight. 🙂

I urge you all to share your favorite discussion of the past week below in the comments. And if you're up for it, give the author an @mention — it'll probably make 'em feel good. 💚