Can you check to see if a string has the same amount of 'x's and 'o's?
Examples input/output:
XO("ooxx") => true
XO("xooxx") => false
XO("ooxXm") => true
XO("zpzpzpp") => true // when no 'x' and 'o' is present should return true
XO("zzoo") => false
Note: The method must return a boolean and be case insensitive. The string can contain any character
This challenge comes from user joh_pot. Thank you to CodeWars, who has licensed redistribution of this challenge under the 2-Clause BSD License!
Want to propose a challenge for a future post? Email yo+challenge@dev.to with your suggestions!
Top comments (56)
Haskell again
dammit kevin
Just being able to use Haskell impresses me lol
I can't do anything useful with it yet, but it's fun to solve coding katas :D.
JavaScript
A solution using regular expressions in JavaScript. Live demo on CodePen.
Oh look, you had already come up with the same idea as I did!
Yes. Although mine looks a bit uglier because I ran into an issue: if the string doesn't have Xs or Os, the result of
match
is null so it fails when trying to do.length
(testcheckXO("zpzpzpp")
on your code).I had to add the fallback into empty array for those cases. But I feel like there has to be a cleaner way of doing the same thing.
Yeah, I found the same issue when I tried to solve it in Codewars. So I had to do the same. Looking through other people's solutions, there's one that I find interesting that uses
split()
instead of a regular expression. Something like this:The split approach is interesting. I was playing with different options, but not with this. Also, I found that using
toLowerCase()
made the code considerably slower, it works considerably faster if you use a regular expression in the split:I think this is my favourite solution. I hadn't checked its speed, but I thought that
toLowerCase()
probably didn't make it any smoother than returning an empty array if there are no matches.I checked different solutions with jsperf and this was the second fastest by a little (but results may vary.)
C π± don't kill me please
Results:
Is it allowed to modify someone elseβs solution? I think you made it a bit more complicated than necessary. Anyone please correct me if Iβm wrong:
C strings end with the null character
'\0'
, so you can skip getting the string length and do a while loop that checks for the null character (strlen
does just that anyway);I didnβt really understand why youβre walking the string from the start and the middle, instead of from beginning to end, so I changed it;
since we then only test for
x
ando
once, I could inline the tests;xc == oc
andd == 88 || d == 120
are already boolean expressions, so you donβt need the ternary operator... ? true : false
or anif(...) return true; else return false;
;since I never used assertions in C, I took the opportunity to try them for the test cases (I intentionally wrote
assert(count_xo("xooxx") == false)
in the tests instead ofassert(! count_xo("xooxx"))
for consistency and readability.Hi and no problem changing the code
The following is indeed not needed:
The loop tests strings from both sides to be more performant. Try doing benchmarks of both versions and post the results. I don't have time right now but might do it in the evening and show you the difference. Or, I might just embarrass myself lol.
Cheers
I wrote this too fast without even thinking too much, so once again, I appreciate your comment. Anyway, I know that inlining helps, but speed wasn't on my priority list for this challenge. :)
Here are my results:
Your code: ~550 nsec
My code: ~1140 nsec
Thumbs up for faster code.
P.S.
I suspected that
strlen
might be the culprit, and I was right.If I change the code like this, I get results similar to yours, around 500 nsec more/less
Nice. I didnβt inline for speed, but for compactness, so that people donβt say C is too complicated, so verbose, etc. :-)
C is my baby, just started embedded C on SBCs, mostly arm 32bit. And people will always say that π€£π
I feel like the C might've already done you in? dang, that's some verbose low-level lang πΆ
Well that's C, just how it is, you either hate it or you love it π. I missed a comma there; what I wanted to say was: guys, please don't kill me, this is C and it's gonna get ugly.
Very easy (and rather fast) in Perl:
It uses the transliteration operator which returns the number of matching characters in scalar context, and numeric comparison imposes scalar context.
The tests:
Perl sorcery π. This syntax always turns me inside out hehe. Nice job π
Sure, but this one is pretty easy to demystify, luckily:
tr/set1/set2/
just replaces characters inset1
with those inset2
(positionally), and returns the number of characters replaced/deleted. So in this code, he just compares the number of X's replaced with the number of O's replaced, and includes the lower-case variants too.The
local($_)
is just there to let him make the code more brief.$_
is the "default input/pattern-searching space", so its like the default argument thattr
will search. But it's also a global, so this lets you make a local copy and set it to be the first argument to the function.If he didn't do that, it might look like this:
So just a bit more verbose.
Thanks for a great explanation :)
How about a reduce to keep it in one loop? (JS)
Oh, nice! I wouldn't have thought to use the array spread syntax to get the array of characters. π©β¨
Bro, nice solution .cud u explain me what is going inside the reduce. And im not able to reproduce it.
It's working for me in chrome just now. Try wrapping the output line in a
console.log
if you're outside a REPLIn the reduce
acc
is the accumulator, keeping a sum of values as they come up. The reduce returns the sum at the end.Each
c
is a character from the string (...str
is an array of the chars fromstr
)c == 'x' || c == 'X'
is obv a boolean. The code uses the fact that in JSNumber(true) == 1
andNumber(false) == 0
, so it's a shorter way of saying:So each x adds one to the sum, and each o subtracts one. If the sum is zero there are the same number of x's as o's
Cool.its workingπ
Javascript (pretty readable):
Well done! I like a one-liner and clever answers as much as the next person HOWEVER I also love seeing elegant, more readable, and even sometimes simplified (broken down more step by step) solutions!
Awesome job!
Thank you Jacob! I have the same opinion! π
How about some ugly oneliner?
Which produces the following output:
It basically works by lowercasing everything and building an array with the number of Xs and Os. After that, it builds a Set with it, and check if the Set size is 1 or 2!
Not a pretty solution, but it seems to work in Ruby
Returns
WAIT. Here's a much cleaner solution in Ruby.
Which returns
This is why you refactor!
It turns out that you could avoid the
#downcase
withstring.count("xX") == string.count("oO")
I don't know whether the performance would be significantly different, though it would avoid creating a couple of extra string instances.
There are some other interesting variations for
#count
, such as using it to count lower case letters with"abGvf".count("a-z")
Very nice! I love your choice of method name π And it's great that you went back to refactor once you realized there were optimizations you could make. No matter what "stakeholders" say about features driving revenue, any developer worth their salt knows that a clean codebase drives features. πππ
Thanks. I can't think of X's and O's without Gossip Girl.
Clean codebases are so much easier to work with. Not to mention, cost and performance savings.
This is my solution, I'm still learning javascript so nothing fancy
Hmmm... Something like this might work in JavaScript
Some comments may only be visible to logged-in visitors. Sign in to view all comments.